[#239] Add contract_address filter to CLI status query#243
Merged
realproject7 merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Scope CLI storyline lookup to current contract to prevent returning data from the wrong contract on storyline ID collisions. Fixes #239 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 17, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The CLI status query now includes the missing contract_address filter and sources the address from @plotlink/sdk, which aligns the CLI lookup with the current contract context.
Findings
- None. The query is now properly scoped to the active StoryFactory address.
Decision
Approving because the status command no longer risks returning storyline data from the wrong contract. CI was still pending at the time of review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.eq("contract_address", STORY_FACTORY_ADDRESS.toLowerCase())to CLI status Supabase querySTORY_FACTORY_ADDRESSfrom@plotlink/sdkconstantsTest plan
plotlink status -s <id>returns data only from current contractFixes #239
🤖 Generated with Claude Code